Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: database editor #135

Merged
merged 28 commits into from
Oct 24, 2024
Merged

feat: database editor #135

merged 28 commits into from
Oct 24, 2024

Conversation

tanmoysrt
Copy link
Member

@tanmoysrt tanmoysrt commented Oct 15, 2024 •
edited
Loading

Related - frappe/press#2178

  • Fetch database schema (all tables of a database and column's definition)
  • Run user provided SQL query
  • Multi line SQL query support
  • Support to show index of columns
  • Testcases

Press PR - frappe/press#2217

@tanmoysrt tanmoysrt mentioned this pull request Oct 15, 2024
Merged
15 tasks
@tanmoysrt
feat: database query runner implemented
f453fb3
@tanmoysrt
chore: code cleanup and ruff format lint
6a7938a
@tanmoysrt
chore:ruff lint
f255605
@tanmoysrt
chore: remove custom error msg and log unknown error from sql runner
b2c166c
@tanmoysrt
feat: multi line sql query support added
849990c
@tanmoysrt
chore: ignore _sql function complexity
db8a406
@tanmoysrt
chore: ruff format
0ef1a70
@tanmoysrt
fix: implement db.atomic based transaction
2616bc6
@tanmoysrt
feat: send failed query to request as well
31f8287
@tanmoysrt
feat: ignore commented sql queries
a6f2f97
@tanmoysrt
feat: send index info with schemas
caaf3fe
@tanmoysrt
feat(Test): added basic structure for writing db method tests
5b53dd8
@tanmoysrt
chore(ci): update workflow to install test python packages
428a0b1
@tanmoysrt
chore(ci): pin version of testcontainers
4ab0f7e
@tanmoysrt
fix(ci): use older version of testcontainers for python < 3.9
1f4fddf
@tanmoysrt
chore: ruff format
e7aeb4e
@tanmoysrt
chore(ci): add cryptography package
d4469ba
@tanmoysrt
chore(ci): add cryptography package
fa2439e
@tanmoysrt
feat: added testcases for _run_sql function
5652143
@tanmoysrt tanmoysrt marked this pull request as ready for review October 22, 2024 05:46
@tanmoysrt tanmoysrt merged commit 112e439 into frappe:master Oct 24, 2024
2 checks passed
@tanmoysrt tanmoysrt deleted the database_editor branch October 24, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tanmoysrt